I updated the css to keep the menu items aligned to the right and it is live now. It is a much bigger job to rearrange the whole thing to be on the left, so I haven't gone that far for now.
PieFed Meta
Discuss PieFed project direction, provide feedback, ask questions, suggest improvements, and engage in conversations related to the platform organization, policies, features, and community dynamics.
Wiki
Looks good, but the sub-menu items still pop up on the left
^edit, thank you for doing this btw!
Should be fixed now. The only issue I can still see is that if a community has a really long display name it will overflow the menu on very small screens.
edit: and it got broke again with a later update...stay tuned
edit edit: works again, and rimu fixed the long name issue
Everything is looking good on my end, thanks again!
The submenus are a good point that I missed when doing this really quick. I am traveling most of today, but should be able to make an improved PR for those tomorrow. It's the same fix, I just missed that applying the css class to a parent element wouldn't translate to the child ones in this case.
Or make it align to the right per default, without any added option. In my opinion it doesn't really make sense to have the menu button on the right and then the items pop up at the left. that's just some unnecessary finger movement.
Yeah with the hamburger menu icon being on the right, the menu items should be too.
I tend to agree, but I still think it would be nice to offer an option if possible. I'm sure not everyone would prefer it on the right side.
Alternatively, maybe the menu icon could be placed on the left side?
I see about two reasons to prefer it that way, being left-handed or using a right-to-left language. But with those, the parent button might want to be on that side as well. It doesn't seem to be very consistent with Android apps. I have some with the menu on the left and some with the menu on the right. And I mean the icon and instance name serves a purpose as well. I click on that regularly to return back to my feed. (And technically we don't need to move the finger, seems the clickable area is the entire width... I can click on the void at the right side and it still opens the menu item.)
I had a look at the CSS. I thought I could fix it by adding a "text-align: right" somewhere for the breakpoint tablet and below... But I'm not an expert on bootstrap and there is submenus with additional headlines and indented items... Maybe this takes a closer look or someone who is faster at the CSS stuff than me.
This should be fixed now and this is exactly what I ended up doing.
Going as far as moving the menu to the left side of the screen is a much bigger lift, so I am not really going to prioritize it right now.
I'm not sure whether this is the solution. Now it's the first level of menu options on the right, and the next level that pops up (the feeds, communities etc) on the left. That's still a mix if left and right and you still need to reach to the left, just one lever further down.
Should be fixed now. The only issue I can still see is that if a community has a really long display name it will overflow the menu on very small screens.
edit: and it got broke again with a later update...stay tuned
edit edit: works again, and rimu fixed the long name issue
Yeah, I'll fix that up. I missed that the css class wasn't inherited to the child elements, so I will just need to apply the breakpoints to the submenu items.